Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka metrics #32402

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Kafka metrics #32402

merged 5 commits into from
Oct 23, 2024

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Sep 5, 2024 •
edited
Loading

Add per worker metric for Kafka poll latency. This is specifically for Dataflow V1 runner.

Next steps would be to extend this to add latency for other RPC calls.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the kafka_metrics branch 16 times, most recently from a1ab6c0 to 627ad7c Compare September 17, 2024 00:05
@Naireen Naireen marked this pull request as ready for review September 17, 2024 04:04
@github-actions GitHub Actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Naireen
Copy link
Contributor Author

Naireen commented Sep 17, 2024

R: @scwhittle

@github-actions GitHub Actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

scwhittle
scwhittle requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@scwhittle scwhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify in PR description that this is for Dataflow V1 runner?

Adding John as he is more familiar with BeamIO in general and may have suggestions on monitoring.

sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java Outdated Show resolved Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java Outdated Show resolved Hide resolved
Naireen added 3 commits September 26, 2024 22:25
Add kafka poll latency metrics
129094b
Address Sam's comments
c03a6e3 
[Dataflow Streaming] Use isolated windmill streams based on job settings (apache#32503)
Add kafka poll latency metrics
3f9d233
@Naireen
Copy link
Contributor Author

Naireen commented Sep 27, 2024

Run Java PreCommit

@Naireen Naireen mentioned this pull request Oct 3, 2024
Open
3 tasks
@johnjcasey johnjcasey merged commit 0ee13b2 into apache:master Oct 23, 2024
24 checks passed
@sjvanrossum
Copy link
Contributor

@Naireen @johnjcasey The changes introduced in this PR assume that a single KafkaUnboundedSource will be assigned a single Kafka topic. As far as I'm aware that is not what the transform allows users to configure, withTopics(), withTopicPartitions() and withTopicPattern() permit multiple topics. If the number of splits is less than the number of topic partitions, then a single split may end up with an assignment consisting of partitions from multiple topics.

Abacn
Abacn reviewed Dec 6, 2024
View reviewed changes
runners/google-cloud-dataflow-java/worker/build.gradle
@@ -54,6 +54,7 @@ def sdk_provided_project_dependencies = [
":runners:google-cloud-dataflow-java",
":sdks:java:extensions:avro",
":sdks:java:extensions:google-cloud-platform-core",
":sdks:java:io:kafka", // For metric propagation into worker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bad code coupling. Fetching static name isn't sufficient justification to introduce this mandatory dependency to Dataflow worker jar. This also makes confluent repository mandatory for user project.

Abacn
Abacn reviewed Dec 6, 2024
View reviewed changes
...va/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
@@ -668,6 +669,10 @@ public static void main(String[] args) throws Exception {
enableBigQueryMetrics();
}

if (DataflowRunner.hasExperiment(options, "enable_kafka_metrics")) {
KafkaSinkMetrics.setSupportKafkaMetrics(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting IO flags in worker, one can utilize the JvmInitializer.runBeforeProcessing mechanism that is introduce a JvmInitializer implementation in org.apache.beam.sdk.io.kafka to initialize the flags on worker. This avoids the need of kafka dependency

@Abacn Abacn mentioned this pull request Dec 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn left review comments

@scwhittle scwhittle scwhittle requested changes

@johnjcasey johnjcasey johnjcasey approved these changes

Assignees
No one assigned
Labels
dataflow io java kafka runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Naireen @sjvanrossum @scwhittle @Abacn @johnjcasey