Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraIO: Fix generic SelectAll clauses provided by ValueProvider<String> causing CassandraIO.read to fail #31623

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

georgecma
Copy link
Contributor

Fix CassandraIO read function failing when withQuery is provided with a generic selectAll query.

Fixes #31622 .


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [N/A] Update CHANGES.md with noteworthy changes.
  • [N/A] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@georgecma
Copy link
Contributor Author

As an aside, running ./gradlew :buildSrc:spotlessApply -PdisableSpotlessCheck=true did not do anything, but PreCommit Spotless check is failing. What should I run to lint my changes?

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor

Abacn commented Jun 17, 2024

there are format check failure

Run './gradlew :sdks:java:io:cassandra:spotlessApply' to fix these violations.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue sounds similar to #24829 and occurring in different code path if clause is a ValueProvider

@georgecma
Copy link
Contributor Author

The issue sounds similar to #24829 and occurring in different code path if clause is a ValueProvider

It looks like it.

On a side note, this issue only occurs on Integration Tests that use CassandraIO. On CassandraIO usage on Dataflow Runner this issue is not replicated.

@georgecma
Copy link
Contributor Author

Fixes #31622

@Abacn Abacn merged commit ef88539 into apache:master Jun 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CassandraIO creates bad query with ValueProvider query string
2 participants