[Bug]: JmsIOTests don't actually verify that the queue is empty

[tilgalas]

What happened?

In some of the tests in the JmsIOTest class (eg. https://github.com/apache/beam/blob/v2.56.0/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java#L235) there's a code that presumably asserts that the queue is empty after the test pipeline finishes its run. I believe the code there is missing a connection.start() call before calling the consumer.receiveNoWait() and thus will never see any outstanding messages in the queue. In other words, the assertNull(msg) that follows cannot ever fail.

Issue Priority

Priority: 3 (minor)

Issue Components

• Component: Python SDK
• Component: Java SDK
• Component: Go SDK
• Component: Typescript SDK
• Component: IO connector
• Component: Beam YAML
• Component: Beam examples
• Component: Beam playground
• Component: Beam katas
• Component: Website
• Component: Spark Runner
• Component: Flink Runner
• Component: Samza Runner
• Component: Twister2 Runner
• Component: Hazelcast Jet Runner
• Component: Google Cloud Dataflow Runner

[tilgalas]

.take-issue