[Bug]: WriteToFiles(output_fn=...) is seemingly unused

[dlwh]

What happened?

There's a ctor argument output_fn to WriteToFiles that isn't used other than setting a member variable that is never read:

beam/sdks/python/apache_beam/io/fileio.py

Line 542 in 0d58d23

output_fn=None,

Issue Priority

Priority: 3 (minor)

Issue Components

• Component: Python SDK
• Component: Java SDK
• Component: Go SDK
• Component: Typescript SDK
• Component: IO connector
• Component: Beam YAML
• Component: Beam examples
• Component: Beam playground
• Component: Beam katas
• Component: Website
• Component: Spark Runner
• Component: Flink Runner
• Component: Samza Runner
• Component: Twister2 Runner
• Component: Hazelcast Jet Runner
• Component: Google Cloud Dataflow Runner

[tvalentyn]

agreed, appears to be never used. We could clean it up and force keyword-only arguments after it. It could be a breaking change for some users, so could also not touch it and add a note that it's unused and leftover for backward compatibiltiy.

[ima-helikoptaaa]

.take-issue

[riteshghorse]

@ima-attac-helikoptaaa are you still working on it?

[tsafacjo]

agreed, appears to be never used. We could clean it up and force keyword-only arguments after it. It could be a breaking change for some users, so could also not touch it and add a note that it's unused and leftover for backward compatibiltiy.

To sum up we shouldn't change it ?

[tvalentyn]

we can still make the clarification in the code that it is unused. Removing is fine too as long as we force keyword-only args.

[hayk2377]

agreed, appears to be never used. We could clean it up and force keyword-only arguments after it. It could be a breaking change for some users, so could also not touch it and add a note that it's unused and leftover for backward compatibiltiy.

should we add a note on the docstring so that it is visible for the caller

[mohamedawnallah]

.take-issue

EDIT:
I'm new here and eager to contribute. Since this issue has been stale for a while and no pull request has been submitted, I would like to take the lead on it! 🙏