Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Clean up logger handling in Python's boot.go script #29819

Open
1 of 16 tasks
jrmccluskey opened this issue Dec 19, 2023 · 6 comments · May be fixed by #33015
Open
1 of 16 tasks

[Task]: Clean up logger handling in Python's boot.go script #29819

jrmccluskey opened this issue Dec 19, 2023 · 6 comments · May be fixed by #33015

Comments

@jrmccluskey
Copy link
Contributor

What needs to happen?

The Python SDK's boot.go script currently wraps Logging API access in a buffer to get appropriately leveled logging output sent across the logging API; however, the current structure accepts a pointer to a Logger then wraps it as needed; this should be cleaned up to pass around a buffered logger directly.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Anuragt1104
Copy link

.take-issue

@ENate
Copy link

ENate commented Jan 24, 2024

Hi @jrmccluskey Is the issue still open? Thanks.

@Anuragt1104 Anuragt1104 removed their assignment Jan 24, 2024
@jrmccluskey
Copy link
Contributor Author

Yes this issue is still open

@ENate
Copy link

ENate commented Jan 24, 2024

Since it is a 'good first issue', I can work on it. But I will have to familiarize myself with the repo. Is that okay?

@jrmccluskey
Copy link
Contributor Author

Yeah of course! It's fortunately a pretty straightforward change to pass the buffered logger around instead of a normal logger and re-wrapping it consistently. If you have any questions let me know!

@willvo2004
Copy link

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants