-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Clean up logger handling in Python's boot.go script #29819
Comments
.take-issue |
Hi @jrmccluskey Is the issue still open? Thanks. |
Yes this issue is still open |
Since it is a 'good first issue', I can work on it. But I will have to familiarize myself with the repo. Is that okay? |
Yeah of course! It's fortunately a pretty straightforward change to pass the buffered logger around instead of a normal logger and re-wrapping it consistently. If you have any questions let me know! |
.take-issue |
What needs to happen?
The Python SDK's boot.go script currently wraps Logging API access in a buffer to get appropriately leveled logging output sent across the logging API; however, the current structure accepts a pointer to a Logger then wraps it as needed; this should be cleaned up to pass around a buffered logger directly.
Issue Priority
Priority: 3 (nice-to-have improvement)
Issue Components
The text was updated successfully, but these errors were encountered: