-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BigQueryIO Documentation #28591
Conversation
- Updated the description regarding failed rows for Storage Write API. - Made `PCollection` formatting consistent.
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@kennknowles Could you take a look at this PR? |
R: @ahmedabu98 |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
Also I think we can remove the sentence If there are data validation errors, the transform will throw a RuntimeException.
That doesn't happen anymore, data validation errors should also go to the failed inserts DLQ
website/www/site/content/en/documentation/io/built-in/google-bigquery.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/io/built-in/google-bigquery.md
Outdated
Show resolved
Hide resolved
…igquery.md Co-authored-by: Ahmed Abualsaud <[email protected]>
…igquery.md Co-authored-by: Ahmed Abualsaud <[email protected]>
@ahmedabu98
QQ I thought the "data validation errors" is this shema validation, isn't it? If no I'll quick fix the document.👍 |
I think data validation refers to schema validation, but I don't think that specific link is related. R rows with mismatched schema do go to the DLQ. In practice most failed rows in the DLQ are due to this. I'm not sure how the behavior was before, but we don't fail the transform/pipeline now. I think the line in the link you sent checks that the coder for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (should probably remove that sentence tho)
…igquery.md - Remove unused sentences Co-authored-by: Ahmed Abualsaud <[email protected]>
@ahmedabu98 Sorry for the delay in getting back to you.
Yes, your comment resolved my QQ . The sentences should be removed. Thanks for letting me know.👍 I have added a new commit.👀. |
Thanks! merging now |
PCollection
formatting consistent.Please add a meaningful description for your change here
fixes #27298
Current documentation mentions
WriteResult.getFailedInserts
does not work for Storage Write API. But nowWriteResult.getFailedStorageApiInserts
will return the failed rows for Storage Write API.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.