Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BigQueryIO Documentation #28591

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

RyuSA
Copy link
Contributor

@RyuSA RyuSA commented Sep 21, 2023

  • Updated the description regarding failed rows for Storage Write API.
  • Made PCollection formatting consistent.

Please add a meaningful description for your change here

fixes #27298

Current documentation mentions WriteResult.getFailedInserts does not work for Storage Write API. But now WriteResult.getFailedStorageApiInserts will return the failed rows for Storage Write API.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

- Updated the description regarding failed rows for Storage Write API.
- Made `PCollection` formatting consistent.
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@RyuSA
Copy link
Contributor Author

RyuSA commented Oct 2, 2023

@kennknowles Could you take a look at this PR?

@liferoad
Copy link
Collaborator

liferoad commented Oct 2, 2023

R: @ahmedabu98

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

Also I think we can remove the sentence If there are data validation errors, the transform will throw a RuntimeException. That doesn't happen anymore, data validation errors should also go to the failed inserts DLQ

@RyuSA
Copy link
Contributor Author

RyuSA commented Oct 5, 2023

@ahmedabu98
Thank you. 👏

Also I think we can remove the sentence If there are data validation errors, the transform will throw a RuntimeException. That doesn't happen anymore, data validation errors should also go to the failed inserts DLQ

QQ I thought the "data validation errors" is this shema validation, isn't it? If no I'll quick fix the document.👍

https://github.com/apache/beam/blob/v2.50.0/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java#L112

@ahmedabu98
Copy link
Contributor

ahmedabu98 commented Oct 5, 2023

QQ I thought the "data validation errors" is this schema validation, isn't it?

I think data validation refers to schema validation, but I don't think that specific link is related. R rows with mismatched schema do go to the DLQ. In practice most failed rows in the DLQ are due to this. I'm not sure how the behavior was before, but we don't fail the transform/pipeline now.

I think the line in the link you sent checks that the coder for the StorageApiWritePayload object exists (this does not validate data schema).

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (should probably remove that sentence tho)

…igquery.md

- Remove unused sentences

Co-authored-by: Ahmed Abualsaud <[email protected]>
@RyuSA
Copy link
Contributor Author

RyuSA commented Oct 9, 2023

@ahmedabu98 Sorry for the delay in getting back to you.

(should probably remove that sentence

Yes, your comment resolved my QQ . The sentences should be removed. Thanks for letting me know.👍

I have added a new commit.👀.

@ahmedabu98
Copy link
Contributor

Thanks! merging now

@ahmedabu98 ahmedabu98 merged commit d170634 into apache:master Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update the document for BigQueryIO features
3 participants