Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Rewrite pytest markers to avoid including ML test suites into a catch-all postcommit suite. #28578

Open
1 of 15 tasks
tvalentyn opened this issue Sep 21, 2023 · 2 comments

Comments

@tvalentyn
Copy link
Contributor

tvalentyn commented Sep 21, 2023

What would you like to happen?

Current test configuration causes confusion for authors of new suites and makes some test suites run twice (see discussions on: #28571 #28534)

Issue Priority

Priority: 2

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn tvalentyn changed the title [Feature Request]: Rewrite pytest markers to avoid including ML test suites into a catch-all poscommit suite. [Feature Request]: Rewrite pytest markers to avoid including ML test suites into a catch-all postcommit suite. Sep 21, 2023
@tvalentyn tvalentyn added P2 and removed P3 labels Sep 21, 2023
@tvalentyn tvalentyn added this to the 2.52.0 Release milestone Sep 21, 2023
@AnandInguva
Copy link
Contributor

AnandInguva commented Sep 26, 2023

if a test is using it_postcommit along with a ML framework marker, it is considered to be an IT test. These IT tests then will be possibly run on Dataflow with the respective requirements file.

We provide both the markers because we want to only collect IT tests of that ML framework but not unit tests.

@damccorm
Copy link
Contributor

I don't think this should be a release blocker. The problem in question is that tests are running more often than they should, which doesn't represent risk to users.

@tvalentyn I'm removing the release blocker, if you disagree feel free to add it back

@damccorm damccorm removed this from the 2.52.0 Release milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants