Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Clean up Java Example PreCommit/PostCommit Dataflow #28561

Open
1 of 15 tasks
Abacn opened this issue Sep 20, 2023 · 0 comments
Open
1 of 15 tasks

[Task]: Clean up Java Example PreCommit/PostCommit Dataflow #28561

Abacn opened this issue Sep 20, 2023 · 0 comments
Assignees

Comments

@Abacn
Copy link
Contributor

Abacn commented Sep 20, 2023

What needs to happen?

Currently we have multiple Example PreCommit/PostCommit on Dataflow:

  • PreCommit Example V1 (8, 11, 17) - run wordcount
  • PostCommit Example V1 (11, 17) - run wordcount and impersonate wordcount
  • PostCommit Example V2(8, 11, 17) - run full example (except wordcount)
  • PostCommit V1 - run full example (except wordcount)
  • PostCommit V2 - run full example (except wordcount)

There are a few issues

  • No Dataflow Pipeline run on runner v2 at PreCommit - this has caused regression escaped e.g. Remove TableSchema to JSON conversion. #28274
  • Wordcount never runs on runner v2 - either on Example PostCommit or the "big" PostCommit
  • Duplicate test run, e.g. both PostCommit V2 and PostCommit Example V2 runs Java example
  • Example tests are defined in two different files (runner/google-cloud-dataflow-java/build.gradle (for runner v1 tests) and runner/google-cloud-dataflow-java/example/build.gradle (for runner v2 tests))

We should put all example tests to example/build.gradle also

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant