Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Python external SchemaTransform with its URN #28540

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

ahmedabu98
Copy link
Contributor

Doing this so that we can identify the transform URN when looking at a pipeline DAG.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #28540 (1a1a6e2) into master (1225dee) will decrease coverage by 0.01%.
Report is 137 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #28540      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.01%     
==========================================
  Files         682      683       +1     
  Lines      100541   100821     +280     
==========================================
+ Hits        72723    72920     +197     
- Misses      26243    26326      +83     
  Partials     1575     1575              
Flag Coverage Δ
python 82.81% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/transforms/external.py 74.26% <50.00%> (-0.10%) ⬇️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
Copy link
Contributor Author

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@ahmedabu98 ahmedabu98 merged commit ef0d8d4 into apache:master Sep 20, 2023
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants