Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][Go SDK]: Generate Postgres compatible placeholders for pgx driver #28520

Closed
1 of 15 tasks
johannaojeling opened this issue Sep 19, 2023 · 1 comment · Fixed by #28521
Closed
1 of 15 tasks

Comments

@johannaojeling
Copy link
Contributor

What would you like to happen?

If using the pgx driver for a Postgres database in databaseio.Write, a prepared statement with default placeholders like "(?,?,?),(?,?,?)" is generated for the values to insert. Include "pgx" in the Postgres value template generation case, so that the value template follows the pattern "($1,$2,$3),($4,$5,$6)" instead.

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@johannaojeling
Copy link
Contributor Author

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant