Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Update beam_PostCommit_Java_IO_Performance_Tests.yml to select release branch automatically #28330

Closed
2 of 15 tasks
johnjcasey opened this issue Sep 6, 2023 · 3 comments · Fixed by #30751
Closed
2 of 15 tasks

Comments

@johnjcasey
Copy link
Contributor

What needs to happen?

beam_PostCommit_Java_IO_Performance_Tests.yml is hardcoded to the most recent release. This should be updated to query the Github releases endpoint, and automatically select the most recent release.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn
Copy link
Contributor

tvalentyn commented Feb 2, 2024

why is this suite testing a release branch as opposed to testing dev SDK?

Also it seems broken as of now:

Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/runner/_work/beam/beam/.github/actions/setup-environment-action'. Did you forget to run actions/checkout before running your local action?

@johnjcasey
Copy link
Contributor Author

This suite is designed to run performance tests, and collect metrics against our released branches. We don't want to add master-branch metrics to our results

@lostluck
Copy link
Contributor

lostluck commented Feb 6, 2024

The suite appears to be Permared at present.

https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml?query=is%3Afailure

In particular the PublishJUnitTestResults step is failing

Warning: Could not find any files for **/build/test-results/**/*.xml

https://github.com/apache/beam/actions/runs/7802551908/job/21280300993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants