Add notebook for per key models #28327
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Should we also include this in the ReadMe list? https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/README.md |
Yes, done! |
| "source": [ | ||
| "## Postprocess our results\n", | ||
| "\n", | ||
| "The `RunInference` transform returns a Tuple of the original key and a `PredictionResult` object that contains the original example and the inference. From that, we will extract the data we care about. We will then group this data by the original example in order to compare each model's prediction." |
There was a problem hiding this comment.
| "The `RunInference` transform returns a Tuple of the original key and a `PredictionResult` object that contains the original example and the inference. From that, we will extract the data we care about. We will then group this data by the original example in order to compare each model's prediction." | |
| "The `RunInference` transform returns the following items:\n", | |
| "\n", | |
| "* A tuple of the original key\n", | |
| "* A `PredictionResult` object that contains the original example and the inference\n", | |
| "\n", | |
| "Use those outputs to extract the relevant data. Then, to compare each model's prediction, group this data by the original example." |
There was a problem hiding this comment.
That changes the meaning (which means it definitely wasn't clear 😅 ). Let me know if it reads better now
There was a problem hiding this comment.
This is the relevant diff - 056d6d2 - the other commit is directly applying all other suggestions
Co-authored-by: Rebecca Szper <[email protected]>
|
I'm going to merge this in the current pull from master form so that it can be easily used for demos. I'll follow up to update the beam install once 2.51 is released |
✨ RENDERED ✨
This should not be merged until 2.51 is released, it was tested by replacing the beam install with a clone/install from the Beam repo though.
Resolves #27628
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.