Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [TextIO] Prevent threads from hanging indefinitely #27395

Closed
1 of 15 tasks
bvolpato opened this issue Jul 7, 2023 · 1 comment
Closed
1 of 15 tasks

[Bug]: [TextIO] Prevent threads from hanging indefinitely #27395

bvolpato opened this issue Jul 7, 2023 · 1 comment

Comments

@bvolpato
Copy link
Contributor

bvolpato commented Jul 7, 2023

What happened?

Recently observed the case where TextIO / WriteFiles was hanging indefinitely on @FinishBundle:

https://github.com/apache/beam/blob/release-2.48.0/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java#L1021-L1034

We are doing MoreFutures.get(MoreFutures.allAsList(closeFutures)), and for some reason, threads are not completing.

I believe we should investigate adding a reasonable timeout (MoreFutures.get(MoreFutures.allAsList(closeFutures), 1, TimeUnit.HOURS)?) to avoid having jobs hanging forever. The work will be retried, so it shouldn't cause any data loss.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn
Copy link
Contributor

Closing as duplicate of #29926

@github-actions github-actions bot added this to the 2.62.0 Release milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants