-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10785] Change RowAsDictJsonCoder to not ensure ASCII while encoding #22312
Conversation
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Signed-off-by: Seunghwan Hong <[email protected]>
c390899
to
e2e4f37
Compare
Signed-off-by: Seunghwan Hong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #22312 +/- ##
==========================================
- Coverage 74.17% 74.16% -0.02%
==========================================
Files 706 706
Lines 93195 93195
==========================================
- Hits 69126 69115 -11
- Misses 22801 22812 +11
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @johnjcasey |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
R: @pabloem as original reviewer |
This looks good to me, but Pablo I think you already have context |
ah yes lgtm! |
merging as tests already passed in previous commit |
This PR fixes BEAM-10785 (#20532 on Github) by an alternative way: Adding
ensure_ascii=False
tojson.dumps
onRowAsDictJsonCoder
.The original way for fixing this issue was enabling
coder
argument on WriteToBigQuery and passing it downstream, but other way was discussed on #17518.Resolves #20532.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.