Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10785] Change RowAsDictJsonCoder to not ensure ASCII while encoding #22312

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

harrydrippin
Copy link
Contributor

@harrydrippin harrydrippin commented Jul 17, 2022

This PR fixes BEAM-10785 (#20532 on Github) by an alternative way: Adding ensure_ascii=False to json.dumps on RowAsDictJsonCoder.

The original way for fixing this issue was enabling coder argument on WriteToBigQuery and passing it downstream, but other way was discussed on #17518.

Resolves #20532.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@harrydrippin
Copy link
Contributor Author

R: @aaltay, @pabloem

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #22312 (3863c33) into master (20274f3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22312      +/-   ##
==========================================
- Coverage   74.17%   74.16%   -0.02%     
==========================================
  Files         706      706              
  Lines       93195    93195              
==========================================
- Hits        69126    69115      -11     
- Misses      22801    22812      +11     
  Partials     1268     1268              
Flag Coverage Δ
python 83.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 85.67% <ø> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20274f3...3863c33. Read the comment docs.

@aaltay
Copy link
Member

aaltay commented Jul 17, 2022

R: @johnjcasey

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 16, 2022
@johnjcasey
Copy link
Contributor

R: @pabloem as original reviewer

@johnjcasey
Copy link
Contributor

This looks good to me, but Pablo I think you already have context

@github-actions github-actions bot removed the stale label Sep 17, 2022
@pabloem
Copy link
Member

pabloem commented Sep 30, 2022

ah yes lgtm!

@pabloem
Copy link
Member

pabloem commented Sep 30, 2022

merging as tests already passed in previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for coder argument in WriteToBigQuery
4 participants