Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigquery import/export should transfer dataflow labels to load job #21529

Closed
damccorm opened this issue Jun 5, 2022 · 1 comment · Fixed by #31698
Closed

Bigquery import/export should transfer dataflow labels to load job #21529

damccorm opened this issue Jun 5, 2022 · 1 comment · Fixed by #31698

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 5, 2022

We add labels to the load / export job but right now it's just a beam-related label and no others. If the user has labels with the dataflow job it would be good to forward these to the load job so that the resources can be looked up properly.

I noticed this in java. I imagine it's an issue in python/go but would be good to check.

Relevant code links:
[1] https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOMetadata.java#L59
[2] https://github.com/apache/beam/blob/11aad9160d3a12e19d593d5819bca9505ded9a3b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L232

Imported from Jira BEAM-14182. Original Jira may contain additional context.
Reported by: laraschmidt.

@Amar3tto
Copy link
Contributor

Amar3tto commented Jul 2, 2024

.take-issue

@github-actions github-actions bot added this to the 2.60.0 Release milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants