Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intuitive default behavior for sdk_location pipeline option #19168

Open
kennknowles opened this issue Jun 3, 2022 · 1 comment
Open

Intuitive default behavior for sdk_location pipeline option #19168

kennknowles opened this issue Jun 3, 2022 · 1 comment
Labels
harness improvement P3 portability python

Comments

@kennknowles
Copy link
Member

The current default value of "default" implies a Dataflow specific behavior of the artifact stager. The same stager is also used by the portable runner, which has to specify a value "container", which actually means to not stage the SDK. That should be the default behavior and the default value for the sdk_location should be None. The Dataflow runner can then specify a value such as "pypi" which conveys more closely the expected behavior.

Imported from Jira BEAM-5525. Original Jira may contain additional context.
Reported by: thw.
@robertwb
Copy link
Contributor

Related: #26996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
harness improvement P3 portability python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robertwb @kennknowles @damccorm