From c7a873cd723b4c0e02ccf77b53b638a52c65cd67 Mon Sep 17 00:00:00 2001 From: Bartosz Zablocki Date: Mon, 25 Nov 2024 14:46:30 +0100 Subject: [PATCH] Remove 'serializable' --- .../beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java | 2 +- .../java/org/apache/beam/sdk/io/solace/broker/SempClient.java | 3 +-- .../beam/sdk/io/solace/it/BasicAuthMultipleSempClient.java | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java index 965fc8741374..14528b3c3dfc 100644 --- a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java +++ b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempBasicAuthClientExecutor.java @@ -56,7 +56,7 @@ * response is 401 Unauthorized, the client will execute an additional request with Basic Auth * header to refresh the token. */ -public class SempBasicAuthClientExecutor implements Serializable { +public class SempBasicAuthClientExecutor { // Every request will be repeated 2 times in case of abnormal connection failures. private static final int REQUEST_NUM_RETRIES = 2; private static final Map COOKIE_MANAGER_MAP = diff --git a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempClient.java b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempClient.java index 465f37c14036..c8c0f577ae96 100644 --- a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempClient.java +++ b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SempClient.java @@ -19,14 +19,13 @@ import com.solacesystems.jcsmp.Queue; import java.io.IOException; -import java.io.Serializable; /** * This interface defines methods for interacting with a Solace message broker using the Solace * Element Management Protocol (SEMP). SEMP provides a way to manage and monitor various aspects of * the broker, including queues and topics. */ -public interface SempClient extends Serializable { +public interface SempClient { /** * Determines if the specified queue is non-exclusive. In Solace, non-exclusive queues allow diff --git a/sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/BasicAuthMultipleSempClient.java b/sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/BasicAuthMultipleSempClient.java index b930270ccac4..637cecdcfd15 100644 --- a/sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/BasicAuthMultipleSempClient.java +++ b/sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/BasicAuthMultipleSempClient.java @@ -29,7 +29,7 @@ * Example class showing how the {@link BasicAuthSempClient} can be extended or have functionalities * overridden. In this case, the modified method is {@link * BasicAuthSempClient#getBacklogBytes(String)}, which queries multiple SEMP endpoints to collect - * acurrate backlog metrics. For usage, see {@link SolaceIOMultipleSempIT}. + * accurate backlog metrics. For usage, see {@link SolaceIOMultipleSempIT}. */ public class BasicAuthMultipleSempClient extends BasicAuthSempClient { private final List sempBacklogBasicAuthClientExecutors;