From b04e67912356fee7f4e5a276bbd417bb0baec0cb Mon Sep 17 00:00:00 2001 From: Bartosz Zablocki Date: Fri, 13 Dec 2024 15:54:08 +0100 Subject: [PATCH] Improve methods' javadoc --- .../beam/sdk/io/solace/broker/JcsmpSessionService.java | 4 ---- .../beam/sdk/io/solace/broker/SessionServiceFactory.java | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java index 6bfefd5b7408..818368a92b9f 100644 --- a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java +++ b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java @@ -139,10 +139,6 @@ private MessageProducer createXMLMessageProducer(SubmissionMode submissionMode) } private MessageReceiver createFlowReceiver() throws JCSMPException, IOException { - if (isClosed()) { - connectReadSession(); - } - Queue queue = checkStateNotNull(queue(), "SolaceIO.Read: Queue is not set."); ConsumerFlowProperties flowProperties = new ConsumerFlowProperties(); diff --git a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java index 3e5cb8c5ed25..fe49e3493657 100644 --- a/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java +++ b/sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java @@ -77,7 +77,7 @@ public abstract class SessionServiceFactory implements Serializable { public abstract SessionService create(); /** - * Do not override. This method is called in the {@link + * This method is called in the {@link * org.apache.beam.sdk.io.solace.SolaceIO.Read#expand(org.apache.beam.sdk.values.PBegin)} method * to set the Queue reference based on {@link * org.apache.beam.sdk.io.solace.SolaceIO.Read#from(Solace.Queue)} or {@link @@ -90,8 +90,8 @@ public final void setQueue(Queue queue) { } /** - * Getter for the queue. Do not override. This is nullable, because at the construction time this - * reference is null. Once the pipeline is compiled and the {@link + * Getter for the queue. This is nullable, because at the construction time this reference is + * null. Once the pipeline is compiled and the {@link * org.apache.beam.sdk.io.solace.SolaceIO.Read#expand(org.apache.beam.sdk.values.PBegin)} method * is called, this reference is valid. *