GH-44008: [C++][Parquet] Add support for arrow::ArrayStatistics: boolean #44009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
kou
force-pushed
the
cpp-parquet-statistics-bool
branch
from
7dddc55 to
9e26ec0
Compare
mapleFU
reviewed
Sep 9, 2024
Comment on lines
+346
to
+347
| array_statistics->min = static_cast<bool>(min); | ||
| array_statistics->max = static_cast<bool>(max); |
There was a problem hiding this comment.
Is min-max useful for boolean? Do they only useful for pruning or agg on same value?
There was a problem hiding this comment.
Yes. If both of min and max are true, we can assume that the column only has true (or null if null_count is not 0).
github-actions
bot
added
awaiting changes
|
I'll merge this in this week if nobody objects it. |
wgtmac
approved these changes
Sep 19, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 192d232. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 29 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Statistics is useful for fast processing.
Target types:
BooleanWhat changes are included in this PR?
Map
ColumnChunkMetaDatainformation toarrow::ArrayStatistics.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.