Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35594: [R][C++] Bump vendored date library #35612

Merged
merged 3 commits into from
May 16, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented May 16, 2023

There was an issue with tzdb 0.4.0 and the shipped arrow tz.cpp.

This PR bumps the vendored version of the date library to commit cc4685a21e4a4fdae707ad1233c61bbaff241f93.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35594 has been automatically assigned in GitHub to PR creator.

@DavisVaughan
Copy link
Contributor

It seems like almost all of the files in https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime are from <date> so it might be worth updating all of them rather than just tz.cpp, just to keep everything in sync with upstream

@pitrou pitrou changed the title GH-35594: [R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp GH-35594: [R][C++] Bump vendored date library May 16, 2023
@pitrou
Copy link
Member

pitrou commented May 16, 2023

Indeed, it seems there are a couple other changes to include:

$ git diff --stat 2e19c006e2218447ee31f864191859517603f59f cc4685a21e4a4fdae707ad1233c61bbaff241f93
 include/date/date.h         |   6 ++--
 include/date/iso_week.h     |  18 +++++++++---
 include/date/ptz.h          | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 include/date/tz.h           |   4 +--
 src/tz.cpp                  | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 test/iso_week/year.pass.cpp |   3 ++
 test/testit                 |   6 ++++
 7 files changed, 282 insertions(+), 45 deletions(-)

@thisisnic thisisnic changed the title GH-35594: [R][C++] Bump vendored date library GH-35594: [R][C++] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp May 16, 2023
@thisisnic
Copy link
Member Author

I think I've got them all now

@thisisnic thisisnic added this to the 12.0.1 milestone May 16, 2023
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @thisisnic !

@pitrou pitrou changed the title GH-35594: [R][C++] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp GH-35594: [R][C++] Bump vendored date library May 16, 2023
@pitrou pitrou merged commit aa057d0 into apache:main May 16, 2023
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`.

This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`.
* Closes: apache#35594

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

Revision: 2d79106

Submitted crossbow builds: ursacomputing/crossbow @ actions-bd3d5e4e25

Task Status
test-r-versions Github Actions

thisisnic added a commit to thisisnic/arrow that referenced this pull request May 18, 2023
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`.

This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`.
* Closes: apache#35594

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@ursabot
Copy link

ursabot commented May 18, 2023

Benchmark runs are scheduled for baseline = f6e4479 and contender = aa057d0. aa057d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.41% ⬆️0.03%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] aa057d02 ec2-t3-xlarge-us-east-2
[Finished] aa057d02 test-mac-arm
[Finished] aa057d02 ursa-i9-9960x
[Finished] aa057d02 ursa-thinkcentre-m75q
[Finished] f6e44794 ec2-t3-xlarge-us-east-2
[Finished] f6e44794 test-mac-arm
[Finished] f6e44794 ursa-i9-9960x
[Finished] f6e44794 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 18, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

raulcd pushed a commit that referenced this pull request May 30, 2023
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`.

This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`.
* Closes: #35594

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] Issue with tzdb 0.4.0 and the shipped arrow tz.cpp
4 participants