-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44711: [Docs][Python] Add missing canonical extension types to PyArrow arrays and datatypes docs #44880
Conversation
@github-actions crossbow submit preview-docs |
Revision: 172e98c Submitted crossbow builds: ursacomputing/crossbow @ actions-14d6423697
|
Thanks for doing this @msebbah. This looks good to me except for the order of the new entries. See my comments above about that.
@kou This covers all the missing items that I was able to identify during 30+ minutes of searching. |
@github-actions crossbow submit preview-docs |
Revision: 73b5813 Submitted crossbow builds: ursacomputing/crossbow @ actions-df9fb0630d
|
@github-actions crossbow submit preview-docs |
Revision: 73b5813 Submitted crossbow builds: ursacomputing/crossbow @ actions-08189ee106
|
In the Scalars section of
These all appear in https://github.com/apache/arrow/blob/main/python/pyarrow/scalar.pxi but are missing here. @msebbah could you please add these, in roughly the same order as they appear in various other lists? Thanks! |
Hi @ianmcook, it should be better now, could you review the PR, please ? |
@github-actions crossbow submit preview-docs |
Revision: 27f6d23 Submitted crossbow builds: ursacomputing/crossbow @ actions-f0f92dea49
|
Thanks @msebbah! |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5207f1e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Some of the canonical extension types which are implemented in PyArrow missing from the PyArrow arrays and datatypes docs pages have been added like JSON, UUID, Decimal256 and Bool8.