-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35804: [CI][Packaging][Conan] Synchronize upstream conan #39729
Conversation
@github-actions crossbow submit -g conan |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Could you make your visibility of the "Members" group in |
@github-actions crossbow submit -g conan |
Thank you for the suggestion! @kou |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
conan-maximum failed to find boost:
I tried to debug it locally with command Replacing the options with
Then I appended
Appending
Finally I changed protobuf requirement from 3.21.9 to 3.21.12 resolved the issue:
|
Does this work? diff --git a/ci/scripts/conan_build.sh b/ci/scripts/conan_build.sh
index b1ee0a8fc2..c1862c16f1 100755
--- a/ci/scripts/conan_build.sh
+++ b/ci/scripts/conan_build.sh
@@ -30,34 +30,34 @@ export CONAN_HOOK_ERROR_LEVEL=40
conan_args=()
conan_args+=(--build=missing)
if [ -n "${ARROW_CONAN_PARQUET:-}" ]; then
- conan_args+=(--options arrow:parquet=${ARROW_CONAN_PARQUET})
+ conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")
fi
if [ -n "${ARROW_CONAN_WITH_BROTLI:-}" ]; then
- conan_args+=(--options arrow:with_brotli=${ARROW_CONAN_WITH_BROTLI})
+ conan_args+=(--options "arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI}")
fi
if [ -n "${ARROW_CONAN_WITH_BZ2:-}" ]; then
- conan_args+=(--options arrow:with_bz2=${ARROW_CONAN_WITH_BZ2})
+ conan_args+=(--options "arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2}")
fi
if [ -n "${ARROW_CONAN_WITH_FLIGHT_RPC:-}" ]; then
- conan_args+=(--options arrow:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
+ conan_args+=(--options "arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC}")
fi
if [ -n "${ARROW_CONAN_WITH_GLOG:-}" ]; then
- conan_args+=(--options arrow:with_glog=${ARROW_CONAN_WITH_GLOG})
+ conan_args+=(--options "arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG}")
fi
if [ -n "${ARROW_CONAN_WITH_JEMALLOC:-}" ]; then
- conan_args+=(--options arrow:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC})
+ conan_args+=(--options "arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC}")
fi
if [ -n "${ARROW_CONAN_WITH_JSON:-}" ]; then
- conan_args+=(--options arrow:with_json=${ARROW_CONAN_WITH_JSON})
+ conan_args+=(--options "arrow/*:with_json=${ARROW_CONAN_WITH_JSON}")
fi
if [ -n "${ARROW_CONAN_WITH_LZ4:-}" ]; then
- conan_args+=(--options arrow:with_lz4=${ARROW_CONAN_WITH_LZ4})
+ conan_args+=(--options "arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4}")
fi
if [ -n "${ARROW_CONAN_WITH_SNAPPY:-}" ]; then
- conan_args+=(--options arrow:with_snappy=${ARROW_CONAN_WITH_SNAPPY})
+ conan_args+=(--options "arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY}")
fi
if [ -n "${ARROW_CONAN_WITH_ZSTD:-}" ]; then
- conan_args+=(--options arrow:with_zstd=${ARROW_CONAN_WITH_ZSTD})
+ conan_args+=(--options "arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD}")
fi
version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \ |
Regarding to Regarding to ProtoBuf, we can change our |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@kou I found the problem: https://github.com/conan-io/conan-center-index/pull/19380/files#diff-8bccf85b8738fe9963099a68c25d98d0160fb1ed06657221ea2daebea2c685f0L273. We cannot replace |
@github-actions crossbow submit -g conan |
|
@github-actions crossbow submit -g conan |
Revision: 8c062fb Submitted crossbow builds: ursacomputing/crossbow @ actions-4b0ee017a9
|
@github-actions crossbow submit -g conan |
Revision: 2a2d398 Submitted crossbow builds: ursacomputing/crossbow @ actions-d779ca6ba6
|
@github-actions crossbow submit -g conan |
Revision: 5259cd0 Submitted crossbow builds: ursacomputing/crossbow @ actions-caea67edfa
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should improve our CMake files to remove this but we can do it as a follow-up task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created #41196 and will work on this.
…ache#39729) ### What changes are included in this PR? Merged upstream conan using `ci/conan/merge_upstream.sh ../conan-center-index/` ### Are these changes tested? Will be tested on CI. ### Are there any user-facing changes? No * Closes: apache#35804 Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 18c74b0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ache#39729) ### What changes are included in this PR? Merged upstream conan using `ci/conan/merge_upstream.sh ../conan-center-index/` ### Are these changes tested? Will be tested on CI. ### Are there any user-facing changes? No * Closes: apache#35804 Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
…ache#39729) ### What changes are included in this PR? Merged upstream conan using `ci/conan/merge_upstream.sh ../conan-center-index/` ### Are these changes tested? Will be tested on CI. ### Are there any user-facing changes? No * Closes: apache#35804 Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
What changes are included in this PR?
Merged upstream conan using
ci/conan/merge_upstream.sh ../conan-center-index/
Are these changes tested?
Will be tested on CI.
Are there any user-facing changes?
No