Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][Packaging] Simplify Numpy resolution on python/requirements-wheel-test.txt #33361

Open
asfimport opened this issue Oct 27, 2022 · 2 comments

Comments

@asfimport
Copy link
Collaborator

When building the new wheels for Python 3.11 I had to modify the version of numpy manually only on python/requirements-wheel-test.txt. See: #14499

We are using oldest-supported-numpy everywhere else so I think this could be refactored to simplify the requirements-wheel-test.txt file.

I am opening this ticket as a follow up from this conversation: https://github.com/apache/arrow/pull/14499/files#r1005619591 See other PRs comment like a proposed patch and test failures as an initial investigation.

Reporter: Raúl Cumplido / @raulcd

Note: This issue was originally created as ARROW-18170. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Joris Van den Bossche / @jorisvandenbossche:
I think we could also simplify this file instead. It is not needed to test with oldest-supported-numpy, since the goal of that is that it should also work on more recent versions. I am not sure why we are complex test requirements file for numpy. I would think we could just list "numpy" to get the latest numpy version that is available for the particular platform.

@asfimport
Copy link
Collaborator Author

Joris Van den Bossche / @jorisvandenbossche:
There is some related discussion about this in #11606 as well

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants