Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export NullBufferBuilder in the arrow crate #6975

Open
alamb opened this issue Jan 13, 2025 · 0 comments · May be fixed by #6976
Open

Re-export NullBufferBuilder in the arrow crate #6975

alamb opened this issue Jan 13, 2025 · 0 comments · May be fixed by #6976
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Jan 13, 2025

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I thought there was a clever optimization for handling data with no nulls which I filed in arrow-rs

However, @tustvold pointed out that NullBufferBuilder has exactly the optimization described

I wondered how I could have missed this before and then I realized that the reason is likely that NullBufferBuilder is not re-exported in the arrow crate

You can see this here:
https://docs.rs/arrow/latest/arrow/index.html?search=NullBufferBuilder

NullBuffer is exported (as arrow::buffer::NullBuffer) however:

You can use NullBufferBuilder only if you explicitly bring in the arrow_buffer crate:
https://docs.rs/arrow-buffer/latest/arrow_buffer/builder/struct.NullBufferBuilder.html

Describe the solution you'd like
Export NullBufferBuilder to be consistent with other structures that are reexported (like arrow::array::BooleanBufferBuilder https://docs.rs/arrow/latest/arrow/array/struct.BooleanBufferBuilder.html)

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant