Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlightSQL] GetCatalogsBuilder does not sort the catalog names #6807

Closed
niebayes opened this issue Nov 27, 2024 · 5 comments · Fixed by #6864
Closed

[FlightSQL] GetCatalogsBuilder does not sort the catalog names #6807

niebayes opened this issue Nov 27, 2024 · 5 comments · Fixed by #6864
Assignees
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Comments

@niebayes
Copy link
Contributor

niebayes commented Nov 27, 2024

The GetCatalogsBuilder does not apply sorting as specified in the documentation comments. In contrast, other builders, such as GetDbSchemasBuilder and GetTablesBuilder, sort the record batch exactly as described in their documentation.

See:

/// The returned data should be ordered by catalog_name.
#[derive(Clone, Copy, PartialEq, ::prost::Message)]
pub struct CommandGetCatalogs {}

And see:

pub fn build(self) -> Result<RecordBatch> {
let Self { catalogs } = self;
let batch = RecordBatch::try_new(
Arc::clone(&GET_CATALOG_SCHEMA),
vec![Arc::new(StringArray::from_iter_values(catalogs)) as _],
)?;
Ok(batch)
}

@alamb
Copy link
Contributor

alamb commented Dec 4, 2024

Thank you for the report @niebayes

@niebayes
Copy link
Contributor Author

niebayes commented Dec 5, 2024

take

@alamb
Copy link
Contributor

alamb commented Dec 5, 2024

Feel free to @ mention me on the PR and I can review

@alamb alamb added the arrow Changes to the arrow crate label Dec 17, 2024
@alamb
Copy link
Contributor

alamb commented Dec 17, 2024

label_issue.py automatically added labels {'arrow'} from #6864

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Dec 17, 2024
@alamb
Copy link
Contributor

alamb commented Dec 17, 2024

label_issue.py automatically added labels {'arrow-flight'} from #6864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants