Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on master: doc check with error: unexpected cfg condition value: gil-refs #6771

Closed
alamb opened this issue Nov 21, 2024 · 1 comment
Labels
arrow Changes to the arrow crate bug development-process Related to development process of arrow-rs

Comments

@alamb
Copy link
Contributor

alamb commented Nov 21, 2024

Describe the bug
For example - https://github.com/apache/arrow-rs/actions/runs/11954573062/job/33324973470

error: unexpected `cfg` condition value: `gil-refs`
  --> arrow/src/pyarrow.rs:79:1
   |
79 | import_exception!(pyarrow, ArrowException);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `arrow-csv`, `arrow-ipc`, `arrow-json`, `chrono-tz`, `csv`, `default`, `ffi`, `force_validate`, `ipc`, `ipc_compression`, `json`, `prettyprint`, `pyarrow`, `pyo3`, `rand`, and `test_utils`
   = help: consider adding `gil-refs` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `-D unexpected-cfgs` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
   = note: this error originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `import_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

error: unexpected `cfg` condition value: `gil-refs`
  --> arrow/src/pyarrow.rs:79:1
   |
79 | import_exception!(pyarrow, ArrowException);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `arrow-csv`, `arrow-ipc`, `arrow-json`, `chrono-tz`, `csv`, `default`, `ffi`, `force_validate`, `ipc`, `ipc_compression`, `json`, `prettyprint`, `pyarrow`, `pyo3`, `rand`, and `test_utils`
   = help: consider adding `gil-refs` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: this error originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `import_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not document `arrow`
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

To Reproduce

cargo update
rustup update
cargo doc --document-private-items --no-deps --workspace --all-features

Expected behavior
CI should pass

Additional context

@alamb alamb added the bug label Nov 21, 2024
@alamb
Copy link
Contributor Author

alamb commented Nov 21, 2024

This actually appears to have been fixed by

(thanks @psvri 🙏 )

@alamb alamb closed this as completed Nov 21, 2024
@alamb alamb changed the title CI is failing on master CI is failing on master: doc check with error: unexpected cfg condition value: gil-refs Nov 21, 2024
@alamb alamb added arrow Changes to the arrow crate development-process Related to development process of arrow-rs labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug development-process Related to development process of arrow-rs
Projects
None yet
Development

No branches or pull requests

1 participant