You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The computation of the number of bytes given a precision seems incorrect, and writing decimal larger than 18 crashes?
Found while working on the corresponding in arrow2.
See parquet's definitions for details, but it seems that decimal_length_from_precision is incorrect because it is not the inverse of the maximum number of digits for a given size of parquets' FixedSizeBytes.
The computation of the number of bytes given a precision seems incorrect, and writing decimal larger than 18 crashes?
Found while working on the corresponding in arrow2.
See parquet's definitions for details, but it seems that
decimal_length_from_precision
is incorrect because it is not the inverse of the maximum number of digits for a given size of parquets' FixedSizeBytes.IMO this is the correct version:
(at least this definition causes arrow2 to write all variants of the decimal type in the
generated_decimal
file and roundtrip with pyarrow)The text was updated successfully, but these errors were encountered: