Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet::record::RowIter cannot be customized with batch_size and defaults to 1024 #4782

Closed
yuri-rs opened this issue Sep 6, 2023 · 1 comment · Fixed by #4783
Closed
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@yuri-rs
Copy link
Contributor

yuri-rs commented Sep 6, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I'd like to read parquet file with custom batch_size using parquet::record::RowIter

Describe the solution you'd like
Allow custom tree builder for parquet::record::RowIter

Describe alternatives you've considered
replace parquet::record::RowIter with own implementation

Additional context
SerializedFileReader::get_row_iter and SerializedRowGroupReader::get_row_iter returns parquet::record::RowIter, so I cannot set custom batch_size to the result anyhow

@yuri-rs yuri-rs added the enhancement Any new improvement worthy of a entry in the changelog label Sep 6, 2023
@tustvold tustvold added the parquet Changes to the parquet crate label Sep 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet'} from #4783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants