Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrowArrayStreamReader Send #4222

Closed
wjones127 opened this issue May 15, 2023 · 1 comment · Fixed by #4232
Closed

Make ArrowArrayStreamReader Send #4222

wjones127 opened this issue May 15, 2023 · 1 comment · Fixed by #4232
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@wjones127
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ArrowArrayStreamReader is not Send, which makes is very difficult to work with in async contexts.

While FFI_ArrowArrayStream shouldn't be Sync, I do think it should be marked Send. From the docs:

The stream source is not assumed to be thread-safe. Consumers wanting to call get_next from several threads should ensure those calls are serialized.

Describe the solution you'd like

If FFI_ArrowArrayStream were marked Send and ArrowArrayStreamReader were refactored to hold the inner type in a Box rather than an Arc, then it would be Send.

Describe alternatives you've considered

Additional context

@wjones127 wjones127 added the enhancement Any new improvement worthy of a entry in the changelog label May 15, 2023
@wjones127 wjones127 self-assigned this May 16, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Jun 2, 2023
@tustvold
Copy link
Contributor

tustvold commented Jun 2, 2023

label_issue.py automatically added labels {'arrow'} from #4232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants