Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight SQL Server missing command type.googleapis.com/arrow.flight.protocol.sql.CommandGetXdbcTypeInfo #4054

Closed
c-thiel opened this issue Apr 11, 2023 · 2 comments · Fixed by #4055
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug

Comments

@c-thiel
Copy link
Contributor

c-thiel commented Apr 11, 2023

Describe the bug
In the flight SQL servers' get_flight_info method, there currently is no method for the
The command itself is defined here:

pub struct CommandGetXdbcTypeInfo {

It should be implemented in this match:

match Command::try_from(message).map_err(arrow_error_to_status)? {

as well as the Server Trait.

Expected behavior
I can implement all Flight SQL Commands without overwriting get_flight_info or using the Fallback.

Further Motivation
This command is actually quite common. When using PowerBI and the Dremio ODBC / Flight driver to connect to a flight server, it get's issued right before the preview of any dataset.

@c-thiel c-thiel added the bug label Apr 11, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Apr 21, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4055

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Apr 21, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow-flight'} from #4055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants