You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although cast kernel uses CastOptions when casting from integer to decimal, its behavior on overflow-checking is incomplete.
For now, it'd check division or multiplication if overflowing on underlying decimal native types (i.e., i128 and i256). But it doesn't check if input integer is overflowing on decimal precision. This causes weird behavior when downstream project (e.g., DataFusion) uses cast kernel to cast integer to decimal.
To Reproduce
Expected behavior
Additional context
The text was updated successfully, but these errors were encountered:
Describe the bug
Although
cast
kernel usesCastOptions
when casting from integer to decimal, its behavior on overflow-checking is incomplete.For now, it'd check division or multiplication if overflowing on underlying decimal native types (i.e., i128 and i256). But it doesn't check if input integer is overflowing on decimal precision. This causes weird behavior when downstream project (e.g., DataFusion) uses
cast
kernel to cast integer to decimal.To Reproduce
Expected behavior
Additional context
The text was updated successfully, but these errors were encountered: