Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unsigned S3 Payloads #3737

Closed
tustvold opened this issue Feb 20, 2023 · 0 comments · Fixed by #3741
Closed

Support Unsigned S3 Payloads #3737

tustvold opened this issue Feb 20, 2023 · 0 comments · Fixed by #3741
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the AWS request signer will always sign request payloads as described here

You can optionally compute the entire payload checksum and include it in signature calculation. This provides added security but you need to read your payload twice or buffer it in memory.

There is, however, the option to perform unsigned requests as described here.

You include the literal string UNSIGNED-PAYLOAD when constructing a canonical request, and set the same value as the x-amz-content-sha256 header value when sending the request to Amazon S3

Describe the solution you'd like

We should provide an option to configure this behaviour, as per AWS recommendation we should default to issuing signed requests, but we could provide an option to configure this.

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Feb 20, 2023
@tustvold tustvold added good first issue Good for newcomers object-store Object Store Interface labels Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant