Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array_value_to_string in arrow-csv #3483

Closed
JayjeetAtGithub opened this issue Jan 6, 2023 · 4 comments · Fixed by #3514
Closed

Use array_value_to_string in arrow-csv #3483

JayjeetAtGithub opened this issue Jan 6, 2023 · 4 comments · Fixed by #3514
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@JayjeetAtGithub
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Standardize arrow-csv writer by using array_value_to_string from arrow-cast while writing out record batches to CSV files similar to arrow-json (See #3449).

@JayjeetAtGithub JayjeetAtGithub added the enhancement Any new improvement worthy of a entry in the changelog label Jan 6, 2023
@JayjeetAtGithub
Copy link
Contributor Author

@alamb @tustvold Continuing the discussion from #3417, currently the arrow-csv writer allows users to pass custom datetime formats besides the defaults. By using array_value_to_string, we would enforce the format and disable the customization. Otherwise, if we still want customization, we can keep both, where we basically fallback to using array_value_to_string when no custom format is supplied by the user. Looking forward to hearing your thoughts on this. Thanks.

@alamb
Copy link
Contributor

alamb commented Jan 11, 2023

I filed #3513 to describe the end user behavior this would produce

@JayjeetAtGithub
Copy link
Contributor Author

@alamb @tustvold Continuing the discussion from #3417, currently the arrow-csv writer allows users to pass custom datetime formats besides the defaults. By using array_value_to_string, we would enforce the format and disable the customization. Otherwise, if we still want customization, we can keep both, where we basically fallback to using array_value_to_string when no custom format is supplied by the user. Looking forward to hearing your thoughts on this. Thanks.

I opened #3514 where I removed datetime format customization support for now and use the format enforced by array_value_to_string.

@tustvold tustvold added the arrow Changes to the arrow crate label Feb 10, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #3514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants