Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_builder Loses Timezone and Decimal Scale Information #3435

Closed
tustvold opened this issue Jan 3, 2023 · 1 comment · Fixed by #3438
Closed

make_builder Loses Timezone and Decimal Scale Information #3435

tustvold opened this issue Jan 3, 2023 · 1 comment · Fixed by #3438
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Jan 3, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

PrimitiveBuilder currently always uses T::DATA_TYPE for the resulting array, this prevents overriding the data type to specify decimal precision, or timestamp timezone. In general this is fine as with_timezone or with_precision_and_scale can be called on the resulting array, but when used in make_builder this information is discarded.

This is at best surprising, and could be considered a bug

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jan 3, 2023
@tustvold tustvold self-assigned this Jan 3, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #3438

@tustvold tustvold added the arrow Changes to the arrow crate label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant