We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
The following table illustrates the current behaviour
The first two could be justified if the start offset included the header, but this is inconsistent with the two subsequent results
To Reproduce
#[test] fn test_header_bounds() { let csv = "a,b\na,b\na,b\na,b\na,b\n"; let tests = [ (None, false, 5), (None, true, 4), (Some((0, 4)), false, 4), (Some((1, 4)), false, 3), (Some((0, 4)), true, 4), (Some((1, 4)), true, 3), ]; for (bounds, has_header, expected) in tests { let mut reader = ReaderBuilder::new().has_header(has_header); if let Some((start, end)) = bounds { reader = reader.with_bounds(start, end); } let b = reader .build(Cursor::new(csv.as_bytes())) .unwrap() .next() .unwrap() .unwrap(); assert_eq!(b.num_rows(), expected); } }
Expected behavior
The bounds shouldn't include the header, i.e. an offset of 1 will return the 2nd row of data irrespective of the presence or not of a header.
Additional context
The text was updated successfully, but these errors were encountered:
label_issue.py automatically added labels {'arrow'} from #3365
label_issue.py
Sorry, something went wrong.
tustvold
Successfully merging a pull request may close this issue.
Describe the bug
The following table illustrates the current behaviour
The first two could be justified if the start offset included the header, but this is inconsistent with the two subsequent results
To Reproduce
Expected behavior
The bounds shouldn't include the header, i.e. an offset of 1 will return the 2nd row of data irrespective of the presence or not of a header.
Additional context
The text was updated successfully, but these errors were encountered: