We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DivideByZero
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, we check the DivideByZero error for all primitive types in modulus: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/arithmetic.rs#L1098
modulus
We should remove this checking for float type because %0.0 is a legal operation: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3a34dc3a346d8c3adc845a646d7e9642
%0.0
Describe the solution you'd like Remove the DivideByZero checking for float type and add tests
Describe alternatives you've considered We could not do this but should comment the reason in the docs.
Additional context
The text was updated successfully, but these errors were encountered:
Close this issue as we should follow the c++ impl
Sorry, something went wrong.
No branches or pull requests
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, we check the
DivideByZero
error for all primitive types inmodulus
: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/arithmetic.rs#L1098We should remove this checking for float type because
%0.0
is a legal operation: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3a34dc3a346d8c3adc845a646d7e9642Describe the solution you'd like
Remove the
DivideByZero
checking for float type and add testsDescribe alternatives you've considered
We could not do this but should comment the reason in the docs.
Additional context
The text was updated successfully, but these errors were encountered: