You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is the follow-up of #1684 (comment).
Describe the solution you'd like
How do we validate offsets now?
check if each offset can be converted to usize
check if each offset exceeds the offset_limit
check if offsets are monotonically increasing
validate each slot.
How could we simplify this process?
check if the last offset exceeds the offset_limit
check if each offset can be converted to usize (actually, this could also be removed. But we need to convert the type of offset to usize, so reserve it)
check if offsets are monotonically increasing
validate each slot.
What will be impacted?
We hope the validation could be somewhat faster (we need the benchmark result)
The Error message will change for some test cases. For example, given an offset buffer
[0, 1, 6, 3, 4, 5]
and offset_limit == 5
We will get an error "Offset invariant failure: offset at position 2 out of bounds: 6 > 5" now, but Offset invariant failure: non-monotonic offset at slot 2: 6 > 3 if we do the simplification.
The text was updated successfully, but these errors were encountered:
alamb
added
arrow
Changes to the arrow crate
and removed
arrow
Changes to the arrow crate
enhancement
Any new improvement worthy of a entry in the changelog
labels
Jun 9, 2022
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is the follow-up of #1684 (comment).
Describe the solution you'd like
How do we validate offsets now?
offset_limit
How could we simplify this process?
offset_limit
usize
(actually, this could also be removed. But we need to convert the type of offset tousize
, so reserve it)What will be impacted?
and
offset_limit == 5
We will get an error
"Offset invariant failure: offset at position 2 out of bounds: 6 > 5"
now, butOffset invariant failure: non-monotonic offset at slot 2: 6 > 3
if we do the simplification.The text was updated successfully, but these errors were encountered: