Possible like/ilike/not_like kernels= escaping problems

[alamb]

Describe the bug
@jwdeitch noted on #1085 (comment) that there may be a problem with regex kernels:

I think there may be an outstanding escaping issue in where right-hand side is '%%%' and you want to match on '(literal%)_(literal%)'.... but this problem may be outside the scope of this fix. :)

To Reproduce
TO BE FILED

[jwdeitch]

Thanks for filing Andrew!

Here is a reproducer test case:

    test_utf8!(
        ilike_utf8_scalar_regex,
        vec!["%%%"],
        vec![r#"\%_\%"#],
        ilike_utf8,
        vec![true]
    );

the
... pat.replace("%", ".*") ...
areas might need to consider a leading \ to know to not make the .* replacement

[Dandandan]

Thanks for filing Andrew!

Here is a reproducer test case:

    test_utf8!(
        ilike_utf8_scalar_regex,
        vec!["%%%"],
        vec![r#"\%_\%"#],
        ilike_utf8,
        vec![true]
    );

the ... pat.replace("%", ".*") ... areas might need to consider a leading \ to know to not make the .* replacement

I guess that's the same/similar as
#415 ?

Do you think so as well?

[jwdeitch]

ah right on. thanks!! that's the same issue

[jwdeitch]

I'll try to submit a patch for this today

[alamb]

@Dandandan sorry about the duplicate -- closing as dupe of #415

[Dandandan]

@Dandandan sorry about the duplicate -- closing as dupe of #415

No worries, thanks for tracking the issue.