From b22e96fc8b7397b14f6b2b936ad825a37358cefd Mon Sep 17 00:00:00 2001 From: Diana Clarke Date: Wed, 9 Feb 2022 08:52:32 -0700 Subject: [PATCH] remove --src-dir --- conbench/README.md | 2 +- conbench/_criterion.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/conbench/README.md b/conbench/README.md index d1a83b4082a0..8c7f38cb398a 100644 --- a/conbench/README.md +++ b/conbench/README.md @@ -27,7 +27,7 @@ $ cd ~/arrow-rs/conbench/ $ conda create -y -n conbench python=3.9 $ conda activate conbench (conbench) $ pip install -r requirements.txt -(conbench) $ conbench arrow-rs --src-dir=/Users/diana/workspace/arrow-rs +(conbench) $ conbench arrow-rs ``` ## Example output diff --git a/conbench/_criterion.py b/conbench/_criterion.py index 7e40ef83ef1e..ba92b82f7c63 100644 --- a/conbench/_criterion.py +++ b/conbench/_criterion.py @@ -68,11 +68,10 @@ def _execute_command(command): class CriterionBenchmark(conbench.runner.Benchmark): - external, iterations = True, None - options = {"src_dir": {"type": str}} + external = True def run(self, **kwargs): - src_dir = kwargs["src_dir"] + os.path.join(os.getcwd(), "..") self._cargo_bench(src_dir) results = _read_results(src_dir) for suite in results: