Import commits from apache/arrow #1
Comments
|
I've tested the commands locally (without the push obviously) and the repository looks good on a first check. Should we run some testing to validate functionality before pushing? |
|
Good point. We can use Hmm. It seems that we misses some files. (There are some "[no test files]".) I haven't looked into them yet but I think that we can work on them as follow-up tasks. |
This doesn't necessarily mean we missed files, not all directories contain test files. I've confirmed I get the same test output running on |
|
Thanks. I didn't know about it. |
|
Thanks @kou the output LGTM. @joellubi @zeroshade unless you want to do some extra testing I would go with the current. |
|
This LGTM, we can do a follow-up PR that will update all of the import paths across the code-base to the new URL |
|
Thanks for confirming this approach. I'll do it soon. FYI: Here are related issues:
apache/arrow#43881 [Go] Notify apache/arrow-go migration to all open PRs
#4 Update package name |
|
Sorry. I haven't done this yet. |
|
We need to remove the protected branch configuration in $ git push origin --force-with-lease main
Enumerating objects: 13921, done.
Counting objects: 100% (13921/13921), done.
Delta compression using up to 24 threads
Compressing objects: 100% (3993/3993), done.
Writing objects: 100% (13921/13921), 13.79 MiB | 2.75 MiB/s, done.
Total 13921 (delta 9809), reused 13212 (delta 9721), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (9809/9809), done.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Cannot force-push to this branch
To github.com:apache/arrow-go.git
! [remote rejected] main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:apache/arrow-go.git' |
https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection > To completely remove all branch protection rules, set the > protected_branches section to null, as such: > > Prevent force pushes > > github: > protected_branches: ~
|
I tried Can we enable force push temporary? #80 |
|
Oh, |
…comments. The reset method allow the data structures to be re-used so they don't have to be allocated over and over again. Closes #6430 from richardartoul/ra/merge-upstream and squashes the following commits: 5a0828187 <Richard Artoul> Add license to test file d76be05ca <Richard Artoul> Add test for data reset d102b1fff <Richard Artoul> Add tests d3e6e6785 <Richard Artoul> cleanup comments c8525aece <Richard Artoul> Add Reset method to int array (#5) 489ca2593 <Richard Artoul> Fix array.setData() to retain before release (#4) 88cd05ff8 <Richard Artoul> Add reset method to Data (#3) 6d1b2775c <Richard Artoul> Add Reset() method to String array (#2) dca230383 <Richard Artoul> Add Reset method to buffer and cleanup comments (#1) Lead-authored-by: Richard Artoul <[email protected]> Co-authored-by: Richard Artoul <[email protected]> Signed-off-by: Sebastien Binet <[email protected]>
|
Pushed! |
We need only commits for https://github.com/apache/arrow/tree/main/go . Other commits such as commits for
.github/aren't needed. We need to adjust other files for this repository.We can do this by the following command lines:
The text was updated successfully, but these errors were encountered: