fixes #933 replace placeholder fmt_as fr ExecutionPlan impls #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
This looks great -- thank you for the contribution @tiphaineruy !
cc @houqp / @andygrove for the ballista changes. I think they are pretty straightforward and non controversial
| ) -> std::fmt::Result { | ||
| match t { | ||
| DisplayFormatType::Default => { | ||
| write!(f, "WindowAggExec") |
There was a problem hiding this comment.
I think might be worth including self.window_expr (aka window_expr: Vec<Arc<dyn WindowExpr>>) as well
You can check out https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/hash_aggregate.rs#L260-L272 for an example
There was a problem hiding this comment.
| DisplayFormatType::Default => { | ||
| write!( | ||
| f, | ||
| "DistributedQueryExec: scheduler_url={}", |
There was a problem hiding this comment.
👍 for including scheduler_url
alamb
approved these changes
Aug 25, 2021
|
Thanks @tiphaineruy |
tiphaineruy
deleted the
add-fmt-as-to-structs-implementing-executionplan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #933.
Rationale for this change
Clearer query EXPLAIN
What changes are included in this PR?
add fmt_as on struct implementing ExecutionPlan
Are there any user-facing changes?
None