add cross join support to ballista #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
commented
Aug 15, 2021
| ExplainNode explain = 12; | ||
| WindowNode window = 13; | ||
| AnalyzeNode analyze = 14; |
There was a problem hiding this comment.
@alamb i reordered the node down here so it's easier to do the counting. I am guessing you put it next to ExplainNode because that's how they should be logically grouped? If so, maybe we could keep it next to ExplainNode and reorder the subsequent fields.
There was a problem hiding this comment.
I don't have a strong preference. rust will tell us when the cases are missing so the order in which they are defined is not all that critical in my opinion
andygrove
approved these changes
Aug 16, 2021
|
Thanks @houqp -- looks nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Ballista should support cross join.
What changes are included in this PR?
Added ser/de for cross join logical and physical nodes.
Are there any user-facing changes?
no