-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ballista support to DataFusion CLI #889
Conversation
looks like code blocks in readme needs to be marked with |
my bad, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the code and it looks good to me. I think we have reasonable CI test coverage for the datafusion-cli
(as it is used in the python integration test suite that @jimexist started).
Thanks @andygrove
.map_err(|e| DataFusionError::Execution(format!("{:?}", e)))?; | ||
Ok(Context::Remote(BallistaContext::remote(h, p, &config))) | ||
} | ||
_ => Ok(Context::Local(ExecutionContext::with_config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 perfect
Sorry that I've been quite busy these days. Will review by end of the week and also see what else i can contribute to. This is exciting! |
Which issue does this PR close?
Closes #886 .
Rationale for this change
Enables a SQL repl for Ballista with minimal effort.
What changes are included in this PR?
datafusion-cli now has new
host
andport
argumentsAre there any user-facing changes?
No