Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update clippy lints for Rust 1.54 #794

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 29, 2021

Rationale:

It's that time again! Rust released 1.54 today which causes some additional clippy errors:

If you run clippy on master after running rustup update you get erros such as the following

error: this expression borrows a reference (`&datafusion::logical_plan::JoinType`) that is immediately dereferenced by the compiler
   --> ballista/rust/core/src/serde/physical_plan/mod.rs:108:21
    |
108 |                     &join_type,
    |                     ^^^^^^^^^^ help: change this to: `join_type`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: aborting due to previous error

error: this expression borrows a reference (`&ballista_core::config::BallistaConfig`) that is immediately dereferenced by the compiler
   --> ballista/rust/client/src/context.rs:136:13
    |
136 |             &guard.config(),
    |             ^^^^^^^^^^^^^^^ help: change this to: `guard.config()`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

...

Changes:

  1. Fix clippy errors by doing its suggestions

@alamb alamb requested review from andygrove and Dandandan July 29, 2021 17:54
@Dandandan Dandandan merged commit 7dde5b1 into apache:master Jul 29, 2021
@Dandandan
Copy link
Contributor

Thanks @alamb for fixing it so fast

@alamb
Copy link
Contributor Author

alamb commented Jul 29, 2021

👍

@alamb alamb deleted the alamb/fix_clippy branch July 29, 2021 18:31
@alamb
Copy link
Contributor Author

alamb commented Jul 29, 2021

LOL here is a sister PR for arrow-rs apache/arrow-rs#631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants