Add Ballista examples #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Jul 25, 2021
alamb
reviewed
Jul 26, 2021
|
|
||
| // execute the query - note that calling collect on the DataFrame | ||
| // trait will execute the query with DataFusion so we have to call | ||
| // collect on the BallistaContext instead and pass it the DataFusion |
alamb
approved these changes
Jul 26, 2021
ballista-examples/Cargo.toml
Outdated
| edition = "2018" | ||
| publish = false | ||
|
|
||
|
|
There was a problem hiding this comment.
I wonder if it is worth adding bin targets here?
As it is I can't run these examples:
(arrow_dev) alamb@MacBook-Pro:~/Software/arrow-datafusion/ballista-examples$ cargo run
error: a bin target must be available for `cargo run`Maybe something like
[[bin]]
name = "dataframe"
path = "src/ballista_dataframe.rs"There was a problem hiding this comment.
I was following the same pattern that we use in datafusion-examples where we use cargo run --example rather than cargo run --bin.
% cargo run --example
error: "--example" takes one argument.
Available examples:
ballista-dataframe
ballista-sql
It is a little odd that we package the examples in their own crate, so maybe packaging them as binaries makes more sense now?
There was a problem hiding this comment.
The main motivation from extracting them into a separate folder/crate for datafusion-examples was to reduce the nr of dependencies and compilation time.
Maybe bin works just as well?
There was a problem hiding this comment.
I have updated this to use --bin now.
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #774 .
Rationale for this change
Examples help new users get started.
What changes are included in this PR?
Are there any user-facing changes?
No