Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedup using join column in wildcard expansion #678

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Jul 5, 2021

Rationale for this change

Follow up for #605. Please review 605 first.

What changes are included in this PR?

Duduplicate using join columns in wildcard projection.

Are there any user-facing changes?

Using join wildcard projection now only projects a single join column from one side of the join clause.

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Jul 5, 2021
@houqp houqp marked this pull request as draft July 5, 2021 07:17
@houqp houqp force-pushed the qp_using_wildcard branch from 6911435 to 68d8efc Compare July 10, 2021 23:51
@houqp houqp marked this pull request as ready for review July 10, 2021 23:54
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and well tested) to me. Thanks @houqp !

@alamb
Copy link
Contributor

alamb commented Jul 13, 2021

I think it is looking great -- thanks @houqp

@alamb alamb merged commit 75a376f into apache:master Jul 13, 2021
@houqp houqp deleted the qp_using_wildcard branch July 13, 2021 19:04
@houqp houqp added bug Something isn't working enhancement New feature or request labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants