Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] benchmark run with compose #666

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Jul 4, 2021

Which issue does this PR close?

Closes #665.

Rationale for this change

The the following command from the README:

docker-compose run ballista-client cargo run benchmark ballista --host ballista-scheduler --port 50050 --query 1 --path /data --format tbl

was failing because --host was taken as an option for docker-compose instead of cargo run benchmark.

Also binding to a folder outside the project folder:

  volumes:
    - ../..:/ballista

is dangerous as you might end up overriding random files on the host filesystem.

What changes are included in this PR?

Removed the binding to ../.. and documentation update.

Are there any user-facing changes?

No

@alamb alamb added the ballista label Jul 6, 2021
@alamb alamb requested a review from andygrove July 6, 2021 17:26
@alamb
Copy link
Contributor

alamb commented Jul 6, 2021

Thanks @rdettai !

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dandandan Dandandan merged commit fdf41ad into apache:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks on docker compose fails
3 participants