Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #665.
Rationale for this change
The the following command from the README:
was failing because
--host
was taken as an option fordocker-compose
instead ofcargo run benchmark
.Also binding to a folder outside the project folder:
is dangerous as you might end up overriding random files on the host filesystem.
What changes are included in this PR?
Removed the binding to
../..
and documentation update.Are there any user-facing changes?
No