Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded PartitionMode from Ballista serde #637

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jun 27, 2021

Which issue does this PR close?

Closes #636.

Rationale for this change

This is needed so that we can implement distributed partitioned joins.

What changes are included in this PR?

  • Remove hard-coded value for HashJoinExec partition_mode in Ballista serde and implement correct serde code.
  • Improved unit test

Are there any user-facing changes?

No.

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Jun 27, 2021
@andygrove andygrove merged commit 62b0349 into apache:master Jun 28, 2021
@andygrove andygrove deleted the serde-partition-mode branch June 28, 2021 14:19
@houqp houqp added the enhancement New feature or request label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-coded partition_mode in Ballista serde for HashJoinExec
3 participants