in ballista also check for UI prettier changes #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 156 156
Lines 27063 27063
=======================================
Hits 20575 20575
Misses 6488 6488 Continue to review full report at Codecov.
|
jimexist
force-pushed
the
update-ballista-prettier
branch
from
a5385e2 to
4110585
Compare
msathis
reviewed
Jun 21, 2021
| npx yarn | ||
| # if you encounter error, try rerun the command below with --write instead of --check | ||
| # and commit the changes | ||
| npx yarn prettier --check **/*.{ts,tsx} |
There was a problem hiding this comment.
@jimexist We should include css also?
msathis
reviewed
Jun 21, 2021
| @@ -52,7 +52,7 @@ | |||
| "devDependencies": { | |||
| "@types/react-table": "^7.0.28", | |||
| "@types/react-timeago": "^4.1.2", | |||
| "prettier": "^2.2.1" | |||
| "prettier": "^2.3.0" | |||
jimexist
force-pushed
the
update-ballista-prettier
branch
from
4110585 to
5037dcd
Compare
andygrove
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
in ballista also check for UI prettier changes
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?