Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cargo.toml in python crate and fix unit test due to hash joins #483

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 3, 2021

Which issue does this PR close?

update cargo.toml in python crate

related #481

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #483 (1b61af3) into master (33ff660) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   75.80%   75.80%           
=======================================
  Files         153      153           
  Lines       25924    25924           
=======================================
  Hits        19652    19652           
  Misses       6272     6272           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ff660...1b61af3. Read the comment docs.

@jimexist jimexist changed the title update cargo.toml in python crate update cargo.toml in python crate and fix unit test due to hash joins Jun 3, 2021
Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit e713bc3 into apache:master Jun 3, 2021
@jimexist jimexist deleted the update-python-crate-deps branch June 4, 2021 00:05
@jorgecarleitao
Copy link
Member

@jimexist , could we consider reverting this PR? I do not think that this is correct: DataFusions' behavior of returning 4 record batches when evaluated over a record batch of 3 entries seems wrong to me.

@jorgecarleitao
Copy link
Member

I flagged this in #523 , and I think that we should address this on the DataFusion side and not on the python bindings (i.e. concatenating the arrays).

@jorgecarleitao
Copy link
Member

Scratch the above, Python should keep the tests as is. If anything, we need to address this on DataFusion, but this PR is great as is. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants